Gnutella Forums - trunk broken

Gnutella Forums (https://www.gnutellaforums.com/)

- Development Open Discussion (https://www.gnutellaforums.com/development-open-discussion/)

- - trunk broken - sorry (https://www.gnutellaforums.com/development-open-discussion/82214-trunk-broken-sorry.html)

arne_bab

March 7th, 2008 04:06 AM

trunk broken - sorry

Hi Gregor,

I just tried to build trunk on another computer than mine, and it seems I broke something.

I'm just trying to find out what it was I broke.

arne_bab

March 7th, 2008 04:07 AM

Besides: I had to take a step back from implementing Credence. I found out that i simply don't have the Java skills this would require (And the guys at university said "sorry, we can't fit that into the requirements for a Praktikum"). Sorry for that, too...

Instead of being able to program on Phex during the Praktikum, I'll now do performance tests to see, if using the technics in Phex (and other p2p networks) would be useful for I/O in clusters.

arne_bab

March 7th, 2008 04:21 AM

At least I know where the breakage came from: I merged the trunk in, then began implementing changes, and then committed the changes... and saw that in svn you _have to_ commit after merging (I was used to that being done automatically as it happens in mercurial... the trap snapped hard).

arne_bab

March 7th, 2008 04:28 AM

Update: A clean checkout builds on my main computer, but not on the other. I'll have to check the java version, it seems.

Update2: the other computer has only Java 1.5, while I use Java 1.6, so this might be the problem.

arne_bab

March 7th, 2008 04:38 AM

Verified. I broke Java 1.5 compatibility. I'll have to check, how to undo that.

As first step, I'll just remove the breaking code.

Here's a diff (since it seems I can't commit anymore).

Code:

Index: src/main/java/phex/utils/InternalFileHandler.java

===================================================================

--- src/main/java/phex/utils/InternalFileHandler.java   (Revision 4144)

+++ src/main/java/phex/utils/InternalFileHandler.java   (Arbeitskopie)

@@ -66,14 +66,14 @@
 

                 // dont add already downloading or shared urns.

                 // If we've got a relativeDownloadDir, download to there.

-                if ( relativeDownloadDir.isEmpty() )

-                {

+                //if ( relativeDownloadDir.isEmpty() )

+                //{

                     downloadUri( uri );

-                }

-                else

-                {

+                //}

+                //else

+                //{

                     downloadUri( uri, relativeDownloadDir );

-                }

+                //}
 

             }

 /*            String uuri = parser.getUpdateURI();

arne_bab

March 7th, 2008 04:44 AM

diff

1 Attachment(s)

diff

arne_bab

March 7th, 2008 04:51 AM

And while I'm saying sorry, I'd like to add some more:
I wanted to transfer the domain for quite some time and didn't get to it. Then KDe lost control over spreadkde.org while trying to transfer it, and I got cold feet... but I forgot to say it whenevery I saw you (gk) online. Sorry for that, too.

How safe is domain transfer really in germany?

arne_bab

March 10th, 2008 03:15 AM

My commit works again (forced password change by sourceforge - I should login at the website a bit more often, it seems ;) ), and I added the semi-workaround, so the trunk should now compile again.

I'll recheck the code with Java 1.5 to get magma downloads into subfolders again, but that will take a bit (that's the reason for just doing the hack now - I just commented out the breaking code - I'll do a proper fix the following weeks).

Besides: Downloading any other download list into subfolders mostly requires extracting the intended name of the folder from teh list, the rest is just a matter of a little copy'n'paste.

All times are GMT -7. The time now is 08:04 AM.