Splitting download segments byte loss?
 

Hello,

I noticed it only once and it's difficult to reproduce, so I'm asking here if anyone have noticed something similar.
I was watching the download window completing one of those 735M downloads, just one candidate was uploading the last segment:
[1] <m> bytes of <m> bytes complete.
[2] <x> bytes of <n> bytes downloading.
[3] <o> bytes of <o> bytes complete.
Then another host was connected (busy) so segment [2] was splitted:
[1] <m> bytes of <m> bytes complete.
[2] <x> bytes of <n-(n-x)/2> bytes downloading.
[4] 0 bytes of <(n-x)/2> bytes queued.
[3] <o> bytes of <o> bytes complete.
As the download of [4] never started the segments are joined just before <x> reaches the <n-(n-x)/2>-barrier:
[1] <m> bytes of <m> bytes complete.
[2] <x> bytes of <n-1> bytes downloading.
[3] <o> bytes of <o> bytes complete.

The downloaded file was corrupt, so where was the byte gone?

I think <x> was odd at the segment splitting point.
Maybe this is a division remainder bug. Or something else went wrong...

Helge

Ohh... good observation. Thanks....
I was able to reproduce it and integrate the fix in the already freezed code for the next release.
You will see the release and fix during the next days.

Gregor

Good reaction time. I'm quick in finding bugs but you're fixing bugs even more quickly!

Helge

;-)
Thank you for reporting all the bugs and suggestions...
That always helps me and as you see I take every issue seriously and try to fix it quickly, if possible.

Gregor

Addendum
 

I downloaded a file with a search results size 4333706 bytes.
Phex release_0_7_2 download completed size 4333699 bytes.
Phex 0_7_3 (unstable) download completed size 4333706 bytes.

Helge

Re: Addendum
 

I hope I understand you right and you like to say: "It works now", or??? ;-)

Gregor

Re: Re: Addendum
 

Yes!

Oh, now you have released 0.7.3 so it's no longer "unstable" :-)

Helge