[BUG] Files kept open in the LW player after playing them

[verdyp]

When a file has stopped being played (or previewed during downloads) in the integrated LW player, it is left open.

This prevents the file of being renamed or annotated or deleted, even from LimeWire. The integrated player apparently maintains a shared read lock on that file without closing it.

The file will apparently be closed only after garbage collection occurs (may require many minutes before the unreferenced File object gets finalized after garbage collection, and thus closed effectively), or until the Java VM is shutdown.

When the player stops, it should close that File instance explicitly.

[backmann]

I've had that problem with other players as well....

Ivan
In the dark we make a brighter light

[sberlin]

Zlatin has added a fix for this. Thanks for reporting it, Philippe.

[et voilà]

I get often hangs when downloading something on CVS version. LW seems to not try all available sources, so I kill the download, restart it in the Library and often by doing so or simply repeat a search to get more sources, the Gui hangs.

Here are the steps to reproduce: 1)start a search for something big. 2) download a file and let the search open 3) cancel DL 4) restart iit from Library 5) if it says DL failure (Échec de téléchargement in French): 6) right click on open search tab and select repeat search. (you might have to cancel and start a dl a couple of times before LW say dl failure)
Java sample: hang 2

Ciao

Edit: Also LW doesn't remember sources when you cancel and then resume download from the Library. LW goes in need more sources even if it was downloadind seconds ago.

[et voilà]

Ok now here are two java samples with a one minute interval between them (before and while in the crash). Java 1.4.2 update 2 from apple and LW from CVS of saturday morning.

The first one is with the download with failure after resum from library.
before

The second one is after I right click on the open search and I click repeat search while hanged

Ciao

[verdyp]

Originally posted by backmann
I've had that problem with other players as well....

Ivan
In the dark we make a brighter light

What other players do with files they have played is not our problem. We can't fix them. It's normal when a file is being played that it is left open with a shared read lock (for performance reason, however with preloading, this should not be necessary).
But any played files should be closed and the lock released when the player is stopped (and even probably when it is paused). More generally, it's a bad idea to leave files open for extended time.