Anyone got the clean 2.3.3 source or build?

Thanks.

2.3.4 has a bug where all your inprogress/uncompleted transfers will be lost if you close the program.

Maybe you could try finding that bug and send a patch to [email protected]. I believe there is a problem with interpreting the downloads.dat in the DownloadManager.

I have neither the knowledge or expertise to precisely locate or fix the bug. I did report it in this forum in the support section but I will e-mail that address and let them know.

Okay, I've got something for you. Deleting lines 98 to 104 of core/com/limegroup/gnutella/DownloadManager.java solves the bug.

Runnable checkpointer=new Runnable() {
public void run() {
if (downloadsInProgress()>0) //optimization
writeSnapshot();
}
};
backend.schedule(checkpointer, 0, SNAPSHOT_CHECKPOINT_TIME);

Those lines cause all the trouble.

Cool thanks. Did you forward that info to the developers?

No, cause I believe it is funny, to let them solve their bugs themselves. They are probably looking through the code right now, wondering where the error could be and wasting valuable time they could use to implement new features.

HARHARHAR

Very funny. Why is that code there if it is useless? I mean does it possibly disable some other functionality or cause a new bug if you remove it?

This is a new feature which saves the downloads.dat every 30 seconds (a bit often for my taste), so if LimeWire crashes, the downloads won't be lost.

However it is called before the downloads.dat is read after starting LimeWire and it blocks that file, so if LimeWire tries to read downloads.dat it fails, because another thread is blocking the file. A better solution is, to move that code to another function, so it is called after the downloads.dat is read. That's what I did with my copy of the LimeWire sources.

P.S. I was only kidding before, when I said I didn't send the developers the changes. Of course I sent them some code which solves the bug, - after planting a malicious trojan into it, that will allow me to access your computer.

Thanks for the explanation. I know you were kidding I was just wondering if you'd alreayd told them or if I should send a followup to my previous e-mail.

Doesn't seem to work for me Hope they fix it soon.